Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildGo{Package,Module}: set trimpath in GOFLAGS #102986

Merged
merged 7 commits into from Nov 17, 2020
Merged

buildGo{Package,Module}: set trimpath in GOFLAGS #102986

merged 7 commits into from Nov 17, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Nov 6, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq
buildGo{Package,Module}: set trimpath in GOFLAGS
09677f1 
Also drop removeReferencesTo

`-trimpath` removes all file system paths from the compiled executable,
this should improve reproducibility.
@zowoq
docker: drop redundant removeReferencesTo
091c4bc
@zowoq
singularity: drop unneeded removeReferencesTo
0378380
@zowoq
minio: drop redundant trimpath flag
003766e
@zowoq zowoq marked this pull request as ready for review November 14, 2020 23:32
@zowoq zowoq requested a review from a team November 14, 2020 23:32
@zimbatm zimbatm mentioned this pull request Nov 16, 2020
Closed
zimbatm
zimbatm approved these changes Nov 16, 2020
View reviewed changes
pkgs/tools/misc/direnv/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/direnv/default.nix Show resolved Hide resolved
@zowoq zowoq merged commit 87aa367 into NixOS:master Nov 17, 2020
@zowoq zowoq deleted the gotrimpath branch November 17, 2020 22:13
@zowoq zowoq mentioned this pull request Nov 18, 2020
Merged
10 tasks
Mic92 referenced this pull request in nix-community/nur-combined Dec 9, 2020
@nur-bot
xeals: f8e172c166 -> e5f7b8f385
fd7d5e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

@Mic92 Mic92 Mic92 left review comments

@zimbatm zimbatm zimbatm approved these changes

@kalbasit kalbasit kalbasit approved these changes

@mmahut mmahut Awaiting requested review from mmahut mmahut is a code owner

Assignees
No one assigned
Labels
6.topic: golang 8.has: documentation 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zowoq @zimbatm @marsam @kalbasit @Mic92