Skip to content

libvorbis: 1.3.6 -> 1.3.7 [20.09] #102989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2020
Merged

libvorbis: 1.3.6 -> 1.3.7 [20.09] #102989

merged 1 commit into from
Nov 6, 2020
+3 −16

Conversation

redvers
Copy link
Member

@redvers redvers commented Nov 6, 2020

New release contains various security fixes. Among others for:

(cherry picked from commit 160f912)

Motivation for this change

Addresses: #99805 - CVE-2018-10392 CVE-2018-10393

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@redvers
libvorbis: 1.3.6 -> 1.3.7
3abda93 
New release contains various security fixes. Among others for:
* CVE-2017-14160
* CVE-2018-10392
* CVE-2018-10393

(cherry picked from commit 160f912)
SuperSandro2000
SuperSandro2000 reviewed Nov 6, 2020
View reviewed changes
pkgs/development/libraries/libvorbis/default.nix

stdenv.mkDerivation rec {
name = "libvorbis-1.3.6";
name = "libvorbis-1.3.7";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about pname and version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a backport so better to minimize the changes.

@ofborg ofborg bot requested a review from ehmry November 6, 2020 05:03
@redvers redvers added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Nov 6, 2020
@redvers redvers changed the title libvorbis: 1.3.6 -> 1.3.7 libvorbis: 1.3.6 -> 1.3.7 [20.09] Nov 6, 2020
@ehmry ehmry merged commit 374a738 into NixOS:release-20.09 Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry

@SuperSandro2000 SuperSandro2000

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@redvers @ehmry @SuperSandro2000