Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign Record to be based on ValueCastable #528

Closed
whitequark opened this issue Nov 6, 2020 · 0 comments · Fixed by #529
Closed

Redesign Record to be based on ValueCastable #528

whitequark opened this issue Nov 6, 2020 · 0 comments · Fixed by #529
Labels
improvement
Milestone
0.3

Comments

@whitequark
Copy link
Member

UserValue will be removed in nMigen 0.4 per RFC #355. Although Record (which currently derives from UserValue) is also slated for deprecation and eventual removal, its replacement is not implemented (or designed) yet, and a significant amount of external code depends on it. Because of this Record will survive significantly longer than UserValue (likely several releases), and has to be unaffected by its removal.

The (undesirable and hazardous!) behavior that Record currently has can be simulated by overriding __getattr__ to make Record behave as if it inherits from Value without actually doing so.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Milestone
0.3
Development

Successfully merging a pull request may close this issue.

Migrate Record to ValueCastable, from UserValue awygle/nmigen
1 participant
@whitequark