Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-appservice-discord: 0.5.2 -> 1.0.0 #102973

Merged
merged 2 commits into from Dec 30, 2020
Merged

matrix-appservice-discord: 0.5.2 -> 1.0.0 #102973

merged 2 commits into from Dec 30, 2020

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Nov 6, 2020 •
edited

Motivation for this change

This updates the matrix-appservice-discord package to the latest available version.
Upstream now uses Yarn instead of NPM, so we now use yarn2nix instead of node2nix.

Due to Discord API changes, the previous version will cease to work after 2020-11-07.
Migration to this newer version being mandatory, this should be backported to the release-20.09 branch as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This was referenced Nov 6, 2020
Closed
Closed
@pacien pacien force-pushed the matrix-appservice-discord-v1.0.0 branch 2 times, most recently from b22ab69 to 845fdde Compare November 6, 2020 22:31
@pacien pacien force-pushed the matrix-appservice-discord-v1.0.0 branch from 845fdde to aadfe62 Compare November 8, 2020 17:31
@pacien pacien force-pushed the matrix-appservice-discord-v1.0.0 branch from aadfe62 to 03abdcb Compare December 2, 2020 02:23
@pacien pacien force-pushed the matrix-appservice-discord-v1.0.0 branch from 03abdcb to 26943cb Compare December 2, 2020 02:32
@pacien pacien marked this pull request as ready for review December 2, 2020 02:57
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/305

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102973 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
1 package built:
  • matrix-appservice-discord

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102973 run on x86_64-darwin 1

1 package failed to build:
  • matrix-appservice-discord
    version = CLTVersion()  # macOS Catalina returns 11.0.0.0.1.1567737322
  File "/nix/store/pjacii8rznr3igdv433a4na0g2y3nxxf-nodejs-14.15.3/lib/node_modules/npm/node_modules/node-gyp/gyp/pylib/gyp/xcode_emulation.py", line 1320, in CLTVersion
    output = GetStdout(['/usr/sbin/pkgutil', '--pkg-info', key])
  File "/nix/store/pjacii8rznr3igdv433a4na0g2y3nxxf-nodejs-14.15.3/lib/node_modules/npm/node_modules/node-gyp/gyp/pylib/gyp/xcode_emulation.py", line 1342, in GetStdout
    job = subprocess.Popen(cmdlist, stdout=subprocess.PIPE)
  File "/nix/store/60ficlmwyiwvkmyzarjz2p8xfxpyk5if-python-2.7.18/lib/python2.7/subprocess.py", line 394, in __init__
    errread, errwrite)
  File "/nix/store/60ficlmwyiwvkmyzarjz2p8xfxpyk5if-python-2.7.18/lib/python2.7/subprocess.py", line 1047, in _execute_child
    raise child_exception
OSError: [Errno 1] Operation not permitted
gyp ERR! configure error
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (/nix/store/pjacii8rznr3igdv433a4na0g2y3nxxf-nodejs-14.15.3/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:351:16)
gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:277:12)
gyp ERR! System Darwin 19.6.0
gyp ERR! command "/nix/store/pjacii8rznr3igdv433a4na0g2y3nxxf-nodejs-14.15.3/bin/node" "/nix/store/pjacii8rznr3igdv433a4na0g2y3nxxf-nodejs-14.15.3/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--release"
gyp ERR! cwd /private/tmp/nix-build-matrix-appservice-discord-modules-1.0.0.drv-0/node_modules/better-sqlite3
gyp ERR! node -v v14.15.3
gyp ERR! node-gyp -v v5.1.0
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! better-sqlite3@7.1.1 build-release: `node-gyp rebuild --release`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the better-sqlite3@7.1.1 build-release script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /private/tmp/nix-build-matrix-appservice-discord-modules-1.0.0.drv-0/yarn_home/.npm/_logs/2020-12-27T11_43_21_878Z-debug.log

builder for '/nix/store/x0dixcfhpbmb27kzlh2bw5dk6i0lk8fs-matrix-appservice-discord-modules-1.0.0.drv' failed with exit code 1
cannot build derivation '/nix/store/ywdzvyg0m9j8ssvz2xy70h0kypvj9q7d-matrix-appservice-discord-1.0.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/ywdzvyg0m9j8ssvz2xy70h0kypvj9q7d-matrix-appservice-discord-1.0.0.drv' failed

@pacien
matrix-appservice-discord: 0.5.2 -> 1.0.0
9474df2 
Upstream now uses Yarn instead of NPM, so we now use yarn2nix instead of
node2nix.
@pacien
nixos/matrix-appservice-discord: update module for v1.0.0
ea84262
@pacien pacien force-pushed the matrix-appservice-discord-v1.0.0 branch from 26943cb to ea84262 Compare December 27, 2020 11:59
@pacien
Copy link
Contributor Author

pacien commented Dec 27, 2020

@SuperSandro2000 Thanks for testing; I updated the package metadata to exclude building on Darwin.

@AndersonTorres AndersonTorres added the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 30, 2020
@AndersonTorres AndersonTorres merged commit dff06f0 into NixOS:master Dec 30, 2020
erictapen pushed a commit that referenced this pull request Jan 14, 2021
@pacien @erictapen
matrix-appservice-discord: 0.5.2 -> 1.0.0
1b3b28b 
Upstream now uses Yarn instead of NPM, so we now use yarn2nix instead of
node2nix.

(cherry picked from commit 9474df2)

Reasons for backporting:

> Due to Discord API changes, the previous version will cease to work
> after 2020-11-07. Migration to this newer version being mandatory,
> this should be backported to the release-20.09 branch as well.

#102973
erictapen pushed a commit that referenced this pull request Jan 14, 2021
@pacien @erictapen
nixos/matrix-appservice-discord: update module for v1.0.0
ec9cb41 
(cherry picked from commit ea84262)

Reasons for backporting:

> Due to Discord API changes, the previous version will cease to work
> after 2020-11-07. Migration to this newer version being mandatory,
> this should be backported to the release-20.09 branch as well.

#102973
@erictapen
Copy link
Member

Backport in ec9cb41.

@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 14, 2021
@midchildan midchildan mentioned this pull request May 26, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dali99 dali99 dali99 approved these changes

@Ma27 Ma27 Awaiting requested review from Ma27

@aaronjanse aaronjanse Awaiting requested review from aaronjanse

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pacien @nixos-discourse @SuperSandro2000 @erictapen @dali99 @AndersonTorres