Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbus: docs: make id's reproducible #102961

Merged
merged 1 commit into from Nov 7, 2020
Merged

dbus: docs: make id's reproducible #102961

merged 1 commit into from Nov 7, 2020

Conversation

raboof
Copy link
Member

@raboof raboof commented Nov 5, 2020 •
edited

Motivation for this change

With this parameter, generating docs from the same sources will produce the
same 'bit-by-bit' result each time.

This is particularly important since dbus is part of the 'minimal' testset at
https://r13y.com/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested for reproducibility with 'nix-build -A dbus --check'

Also submitted for upstream master (though it's a bit different there due to changes since the last stable release): https://gitlab.freedesktop.org/dbus/dbus/-/merge_requests/189

@ofborg ofborg bot requested a review from worldofpeace November 5, 2020 20:35
@raboof raboof changed the base branch from master to staging November 6, 2020 14:16
worldofpeace
worldofpeace suggested changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you soo much. I was just looking at this the other day and noticed the ids.
Could you add a comment with links to the documentation on the flag?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/hydra-security-model-discussion/9801/12

@raboof
dbus: docs: make id's reproducible
13d86cc 
With this parameter, generating docs from the same sources will produce the
same 'bit-by-bit' result each time.

This is particularly important since dbus is part of the 'minimal' testset at
https://r13y.com/

Also submitted upstream (though in a slightly different form):
https://gitlab.freedesktop.org/dbus/dbus/-/merge_requests/189
worldofpeace
worldofpeace approved these changes Nov 7, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@worldofpeace worldofpeace merged commit b08a133 into NixOS:staging Nov 7, 2020
@worldofpeace
Copy link
Contributor

I'm cool backporting this to 20.09 if that's desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raboof @nixos-discourse @worldofpeace