Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keycloak: 11.0.2 -> 11.0.3 #102948

Merged
merged 1 commit into from Nov 5, 2020
Merged

keycloak: 11.0.2 -> 11.0.3 #102948

merged 1 commit into from Nov 5, 2020

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Nov 5, 2020

Motivation for this change

Update keycloak to the latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member

mweinelt commented Nov 5, 2020

Thanks for taking care of keycloak. I've noticed you added a module recently. Can you also look into adding a small test case?

@talyz
Copy link
Contributor Author

talyz commented Nov 5, 2020

@mweinelt I've added two test cases as well, one for each database backend. You can run them by building the keycloak.tests attribute. I'm currently waiting on the result of building it locally. ofborg should also build the tests once it's available. :)

@mweinelt
Copy link
Member

mweinelt commented Nov 5, 2020

My bad, I was checking on an old checkout.

Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and ran the tests. LGTM

@talyz
Copy link
Contributor Author

talyz commented Nov 5, 2020

@mweinelt Ah, I see; no problem :) Great! The tests ran successfully on my end too.

@talyz talyz mentioned this pull request Nov 5, 2020
10 tasks
@talyz talyz merged commit 966791f into NixOS:master Nov 5, 2020
@talyz talyz deleted the keycloak-11.0.3 branch November 5, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants