Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins: Added vim-racket and vim-lsp-cxx-highlight #102947

Merged
merged 3 commits into from Nov 7, 2020
Merged

vimPlugins: Added vim-racket and vim-lsp-cxx-highlight #102947

merged 3 commits into from Nov 7, 2020

Conversation

Mazurel
Copy link
Member

@Mazurel Mazurel commented Nov 5, 2020

Motivation for this change

Plugins for using racket language https://github.com/wlangstroth/vim-racket and proper syntax highlighting for c++ for vim https://github.com/jackguo380/vim-lsp-cxx-highlight

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102947 run on x86_64-linux 1

21 packages built:
  • vimPlugins.ale
  • vimPlugins.asyncomplete-vim
  • vimPlugins.caw-vim
  • vimPlugins.coc-nvim
  • vimPlugins.deoplete-fish
  • vimPlugins.deoplete-khard
  • vimPlugins.deoplete-nvim
  • vimPlugins.dracula-vim
  • vimPlugins.lightline-vim
  • vimPlugins.lsp_extensions-nvim
  • vimPlugins.nvim-treesitter
  • vimPlugins.syntastic
  • vimPlugins.vim-airline
  • vimPlugins.vim-airline-themes
  • vimPlugins.vim-android
  • vimPlugins.vim-clap
  • vimPlugins.vim-devicons
  • vimPlugins.vim-lsp
  • vimPlugins.vim-lsp-cxx-highlight
  • vimPlugins.vim-polyglot
  • vimPlugins.vim-racket

@jonringer
Copy link
Contributor

sorry, looks like I missed this, do you mind cleaning up the git history? should be 3 commits

update
add
add

Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches and squash the fix-up commits.

git rebase -i works well for this I created a small video demonstrating it's use here. A more indepth text tutorial can be found here

@Mazurel
Copy link
Member Author

Mazurel commented Nov 7, 2020

I have squashed unnecessary commits. Sorry for the problem, I was using the update.py --add tool and it has added those empty commits, I am not really sure why.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 102947 1

21 packages built:
  • vimPlugins.ale
  • vimPlugins.asyncomplete-vim
  • vimPlugins.caw-vim
  • vimPlugins.coc-nvim
  • vimPlugins.deoplete-fish
  • vimPlugins.deoplete-khard
  • vimPlugins.deoplete-nvim
  • vimPlugins.dracula-vim
  • vimPlugins.lightline-vim
  • vimPlugins.lsp_extensions-nvim
  • vimPlugins.nvim-treesitter
  • vimPlugins.syntastic
  • vimPlugins.vim-airline
  • vimPlugins.vim-airline-themes
  • vimPlugins.vim-android
  • vimPlugins.vim-clap
  • vimPlugins.vim-devicons
  • vimPlugins.vim-lsp
  • vimPlugins.vim-lsp-cxx-highlight
  • vimPlugins.vim-polyglot
  • vimPlugins.vim-racket

@jonringer jonringer merged commit 0c6e5e1 into NixOS:master Nov 7, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102947 run on x86_64-darwin 1

1 package built:
  • vimPlugins.vim-clap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants