8255616: Disable AOT and Graal in Oracle OpenJDK #960
Conversation
|
👋 Welcome back kvn! A progress list of the required criteria for merging this PR into |
|
@vnkozlov The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
openjdk
bot
added
serviceability
|
@vnkozlov This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 32 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
Looks good. |
|
Mailing list message from Andrew Haley on build-dev: On 30/10/2020 17:47, Vladimir Kozlov wrote:
That makes sense: people using AOT compilation are using Graal Subtrate -- |
|
Thank you for reviews. |
|
/integrate |
openjdk
bot
added
integrated
|
@vnkozlov Since your change was applied there have been 43 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 2f7d34f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Reviewed-by: iignatyev, vlivanov, iveresov, ihse
|
Mailing list message from Volker Simonis on hotspot-dev: Hi Vladimir, this is an interesting step and I wonder how it affects the OpenJDK - Project Graal [1] seems to have already been merged into project - Project Metropolis [2] has the following mission statement on its It seems that this goal becomes void when Graal AOT and Grall JIT are - Project Leyden [?]: @mark: what's actually the state of Project Considering the fact that Leyden was supposed to "be based upon Thank you and best regards, [1] http://openjdk.java.net/projects/graal/ On Fri, Oct 30, 2020 at 6:47 PM Vladimir Kozlov <kvn at openjdk.java.net> wrote: |
|
Mailing list message from Monica Beckwith on hotspot-dev: Hi all, First of all, big thanks to Volker for starting this discussion. As you all may have seen from the PRs we submitted last week [1] and our previous PR [2], we have been working on enabling JVMCI and AOT for Windows on Arm64. So RFR 8255616 came in as a surprise to us. It would be really helpful for us to understand the implication of 8255616 on Projects Metropolis and Leyden. We had started looking at Metropolis but more details on Leyden are hard to find. Given the interdependence of both these projects on the Graal compiler and the AOT/jaotc compiler, (as echoed by Volker), we would appreciate any guidance as to the future of these projects and of startup related improvements to C2. Regards, Monica From: hotspot-dev <hotspot-dev-retn at openjdk.java.net> this is an interesting step and I wonder how it affects the OpenJDK - Project Graal [1] seems to have already been merged into project - Project Metropolis [2] has the following mission statement on its It seems that this goal becomes void when Graal AOT and Grall JIT are - Project Leyden [?]: @mark: what's actually the state of Project Considering the fact that Leyden was supposed to "be based upon Thank you and best regards, [1] https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fopenjdk.java.net%2Fprojects%2Fgraal%2F&data=04%7C01%7Cmonica.beckwith%40microsoft.com%7Cfb701afe07bf4350b1c808d87fe68de3%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637399975490480155%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=ByrtmJ4lUa%2FoMsb1IEVM84FdUOEpT490i6BDVgvodBM%3D&reserved=0 On Fri, Oct 30, 2020 at 6:47 PM Vladimir Kozlov <kvn at openjdk.java.net> wrote:
|
|
Mailing list message from Vladimir Kozlov on hotspot-dev: Hi, Volker and Monica On 11/3/20 2:51 AM, Volker Simonis wrote:
This page is outdated and currently incorrect. The main development of Graal is done in GraalVM. OpenJDK and Metropolis are downstream.
No, this goal is still valid. We still think "Java-on-Java" is right direction for some components of HotSpot. We learned a lot and made some progress with Graal as JIT in Metropolis. And we have got very good expertise from AOT We will return to work on Metropolis later on. But right now, we think the work on C2 improvement is more important to I will let Mark to talk about Project Leyden. Best regards,
|
|
Mailing list message from mark.reinhold at oracle.com on hotspot-dev: 2020/11/4 14:53:47 -0800, vladimir.kozlov at oracle.com:
Unfortunately, due to other priorities I haven?t had the time to get
We are considering the possibility of using C2 for ahead-of-time - Mark |
|
Mailing list message from Volker Simonis on hotspot-dev: On Thu, Nov 5, 2020 at 12:06 AM <mark.reinhold at oracle.com> wrote:
Vladimir, Mark, thanks a lot for your answers. Best regards,
|
|
Mailing list message from Monica Beckwith on hotspot-dev: Thanks Vladimir and Mark. Great to hear the positivity in your replies. Please let me know how we can be of help. Regards, Monica Get Outlook for Android<https://aka.ms/ghei36> ________________________________ 2020/11/4 14:53:47 -0800, vladimir.kozlov at oracle.com:
Unfortunately, due to other priorities I haven?t had the time to get
We are considering the possibility of using C2 for ahead-of-time - Mark |
We shipped Ahead-of-Time compilation (the jaotc tool) in JDK 9, as an experimental feature. We shipped Graal as an experimental JIT compiler in JDK 10. We haven't seen much use of these features, and the effort required to support and enhance them is significant. We therefore intend to disable these features in Oracle builds as of JDK 16.
We'll leave the sources for these features in the repository, in case any one else is interested in building them. But we will not update or test them.
We'll continue to build and ship JVMCI as an experimental feature in Oracle builds.
Tested changes in all tiers.
I verified that with these changes I still able to build Graal in open repo and run graalunit testing:
open$ bash test/hotspot/jtreg/compiler/graalunit/downloadLibs.sh /mydir/graalunit_lib/open$ bash configure --with-debug-level=fastdebug --with-graalunit-lib=/mydir/graalunit_lib/ --with-jtreg=/mydir/jtregopen$ make jdk-imageopen$ make test-imageopen$ make run-test TEST=compiler/graalunit/HotspotTest.javaProgress
Testing
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/960/head:pull/960$ git checkout pull/960