Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slither analyzer #102966

Merged
merged 2 commits into from Nov 6, 2020
Merged

Slither analyzer #102966

merged 2 commits into from Nov 6, 2020

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change

#101873 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Nov 5, 2020
Merged
10 tasks
@ofborg ofborg bot requested a review from asymmetric November 5, 2020 21:16
@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 102966 run on x86_64-darwin 1

4 packages built:
  • python37Packages.crytic-compile
  • python37Packages.slither-analyzer
  • python38Packages.crytic-compile
  • slither-analyzer (python38Packages.slither-analyzer)

@fare
Copy link
Contributor

fare commented Nov 5, 2020

LGTM

@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Nov 6, 2020 •
edited

Result of nixpkgs-review pr 102966 run on x86_64-linux 1

2 packages failed to build:
  • python37Packages.slither-analyzer
  • slither-analyzer (python38Packages.slither-analyzer)
2 packages built:
  • python37Packages.crytic-compile
  • python38Packages.crytic-compile
Obtained result:                                                                                                                                                                  [25/45811]  Warning: (105-123): Error trying to invoke SMT solver.                                                                                                                                                                                                                                                                                                                                /solidity/test/boostTest.cpp(109): error: in "smtCheckerTests/operators/compound_assignment_division_3": Test expectation mismatch.                                                         Expected result:                                                                                                                                                                              Warning: (194-213): Assertion violation happens here                                                                                                                                      Obtained result:                                                                                                                                                                              Warning: (171-190): Error trying to invoke SMT solver.                                                                                                                                      Warning: (194-213): Error trying to invoke SMT solver.                                                                                                                                      Warning: (194-213): Assertion violation happens here                                                                                                                                                                                                                                                                                                                                  /solidity/test/boostTest.cpp(109): error: in "smtCheckerTests/operators/division_truncates_correctly_3": Test expectation mismatch.                                                         Expected result:                                                                                                                                                                              Success                                                                                                                                                                                   Obtained result:                                                                                                                                                                              Warning: (106-125): Error trying to invoke SMT solver.

/solidity/test/boostTest.cpp(109): error: in "smtCheckerTests/operators/division_truncates_correctly_1": Test expectation mismatch.
Expected result:
  Success
Obtained result:
  Warning: (107-125): Error trying to invoke SMT solver.

/solidity/test/boostTest.cpp(109): error: in "smtCheckerTests/operators/delete_array_index_2d": Test expectation mismatch.
Expected result:
  Warning: (174-194): Assertion violation happens here
Obtained result:
  Success

/solidity/test/boostTest.cpp(109): error: in "smtCheckerTests/operators/division_truncates_correctly_5": Test expectation mismatch.
Expected result:
  Success
Obtained result:
  Warning: (107-125): Error trying to invoke SMT solver.

Those solc tests are so flaky and my nixpkgs-review always fails to build the package.

jonringer
jonringer approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/102966
2 packages failed to build:
python37Packages.slither-analyzer slither-analyzer

2 packages built:
python37Packages.crytic-compile python38Packages.crytic-compile

@jonringer jonringer merged commit 11d53d3 into NixOS:master Nov 6, 2020
@SuperSandro2000 SuperSandro2000 deleted the slither-analyzer branch November 6, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@asymmetric asymmetric Awaiting requested review from asymmetric

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SuperSandro2000 @fare @jonringer