Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wally-cli: enable on darwin #102993

Merged
merged 2 commits into from Nov 7, 2020
Merged

wally-cli: enable on darwin #102993

merged 2 commits into from Nov 7, 2020

Conversation

r-burns
Copy link
Contributor

@r-burns r-burns commented Nov 6, 2020

Works for me on my mac! Since @spacekookie might not have signed up for darwin maintenance, I can help out on that front.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) labels Nov 6, 2020
@ofborg ofborg bot requested review from spacekookie and kalbasit November 6, 2020 05:29
@marsam marsam merged commit cb9fab8 into NixOS:master Nov 7, 2020
@r-burns r-burns deleted the wally branch November 7, 2020 06:17
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102993 run on x86_64-darwin 1

1 package built:
  • wally-cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacekookie spacekookie Awaiting requested review from spacekookie

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@r-burns @SuperSandro2000 @marsam