Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postfix: 3.5.6 -> 3.5.7 #102981

Closed
wants to merge 1 commit into from
Closed

postfix: 3.5.6 -> 3.5.7 #102981

wants to merge 1 commit into from

Conversation

asbachb
Copy link
Contributor

@asbachb asbachb commented Nov 6, 2020 •
edited

Motivation for this change

changelog: https://www.postfix.org/announcements/postfix-3.5.7.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
 asbachb@nixo-t14s  ~/dev/src/nix/nixpkgs   update/postfix  nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
remote: Enumerating objects: 5, done.
remote: Counting objects: 100% (5/5), done.
remote: Compressing objects: 100% (5/5), done.
remote: Total 8 (delta 0), reused 0 (delta 0), pack-reused 3
Unpacking objects: 100% (8/8), 13.23 KiB | 13.23 MiB/s, done.
From https://github.com/NixOS/nixpkgs
 * [new branch]              master     -> refs/nixpkgs-review/0
$ git worktree add /home/asbachb/.cache/nixpkgs-review/rev-0ed288f66778af9c3c8ba5cbb568ea166ed32830-dirty/nixpkgs 11fc05583669cf3cb8c99dc6cb6f6ca7d93fa01d
Preparing worktree (detached HEAD 11fc0558366)
HEAD is now at 11fc0558366 pam_mount: add support for LUKS2
$ nix-env -f /home/asbachb/.cache/nixpkgs-review/rev-0ed288f66778af9c3c8ba5cbb568ea166ed32830-dirty/nixpkgs -qaP --xml --out-path --show-trace
No diff detected, stopping review...
$ git worktree prune
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from globin November 6, 2020 02:22
@asbachb
Copy link
Contributor Author

asbachb commented Nov 6, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 6, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@ajs124
Copy link
Member

ajs124 commented Nov 6, 2020

duplicate of #102719?

@asbachb
Copy link
Contributor Author

asbachb commented Nov 6, 2020

You're right.

@asbachb asbachb closed this Nov 6, 2020
@asbachb asbachb deleted the update/postfix branch January 25, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asbachb @ajs124