Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

megasync: 4.3.1.0 -> 4.3.5.0 #102985

Merged
merged 2 commits into from Nov 6, 2020
Merged

Conversation

michojel
Copy link
Contributor

@michojel michojel commented Nov 6, 2020

formatted with nix-community/nixpkgs-fmt

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Resolves NixOS#102634

Signed-off-by: Michal Minář <mic.liamg@gmail.com>
@michojel
Copy link
Contributor Author

michojel commented Nov 6, 2020

Resolves #102634

@michojel
Copy link
Contributor Author

michojel commented Nov 6, 2020

/CC @kisik21 @JonathanReeve @bhipple

Signed-off-by: Michal Minář <mic.liamg@gmail.com>
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 102985 1

1 package built:
  • megasync

@jonringer jonringer merged commit bf8f067 into NixOS:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants