Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argocd: 1.4.2 -> 1.7.8 #102970

Merged
merged 1 commit into from Nov 9, 2020
Merged

argocd: 1.4.2 -> 1.7.8 #102970

merged 1 commit into from Nov 9, 2020

Conversation

glittershark
Copy link
Member

Motivation for this change

Version bump of argocd

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@glittershark
Copy link
Member Author

cc @shahrukh330

@rissson
Copy link
Member

rissson commented Nov 7, 2020

Looks good to me. Tested with a 1.7.8 server.

Copy link
Contributor

@shahrukh330 shahrukh330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alyssais alyssais merged commit c54bb4e into NixOS:master Nov 9, 2020
@glittershark glittershark deleted the bump-argocd branch November 9, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants