-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
android-image-utils: init at 2012-08-08 #102959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
stdenv.mkDerivation rec { | ||
pname = "android-image-utils"; | ||
version = "2012-08-08"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package is really old and the last commit is 8 years old. Also it probably needs updates for newer Android versions past 4.4. Is there any good reason why it still should be added to nixpkgs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used it yesterday in an attempt to fix my phone, so I figured I'd PR it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is still pretty old and probably needs patches in the future to work when packages it relies on get updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is pretty old, true.
It only depends on zlib and that seems to be a pretty a stable library, no?
On the other hand, this looks like a pretty niche package, and it has hardly any documentation, so that might be a reason not to ad it.
I only PR'd it cause I had built it since I needed it, so it was easy enough for me to offer it to the community and let you all decide if it should be in nixpkgs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an alternative for such outdated packages, consider contributing to NUR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, since upstream is unmaintained, the NUR seems to be the most appropriate place.
caa1416
to
7173d16
Compare
7173d16
to
51ebd61
Compare
I marked this as stale due to inactivity. → More info |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)