Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_1password-gui: 0.9.1 -> 0.9.2-1 #102958

Merged
merged 1 commit into from Nov 6, 2020
Merged

_1password-gui: 0.9.1 -> 0.9.2-1 #102958

merged 1 commit into from Nov 6, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Nov 5, 2020

Motivation for this change

Changes:

https://1password.community/discussion/116663/1password-beta-0-9-2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102958 run on x86_64-linux 1

1 package built:
  • _1password-gui

@danieldk
Copy link
Contributor Author

danieldk commented Nov 6, 2020

Result of nixpkgs-review pr 102958 run on x86_64-linux 1

1 package built:

Thanks! Does it work for you as well?

@SuperSandro2000
Copy link
Member

Thanks! Does it work for you as well?

Didn't try to use it.

@danieldk
Copy link
Contributor Author

danieldk commented Nov 6, 2020

Ack. Anyway, the 1password version bumps haven't led to any problems yet, so let's just merge this, before there is yet another release ;).

@danieldk danieldk merged commit 945e616 into NixOS:master Nov 6, 2020
@danieldk danieldk deleted the 1password-0.9.2 branch November 6, 2020 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @SuperSandro2000