Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plexamp: 3.2.0 -> 3.3.1 #102972

Merged
merged 1 commit into from Nov 6, 2020
Merged

plexamp: 3.2.0 -> 3.3.1 #102972

merged 1 commit into from Nov 6, 2020

Conversation

afontaine
Copy link
Contributor

@afontaine afontaine commented Nov 6, 2020 •
edited

Motivation for this change

Release notes: https://forums.plex.tv/t/plexamp-release-notes/221280/20

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@afontaine
Copy link
Contributor Author

Result of nixpkgs-review pr 102972 1

1 package built:
  • plexamp

@ofborg ofborg bot requested a review from killercup November 6, 2020 00:30
SuperSandro2000
SuperSandro2000 reviewed Nov 6, 2020
View reviewed changes
pkgs/applications/audio/plexamp/default.nix
@@ -2,13 +2,13 @@

let
pname = "plexamp";
version = "3.2.0";
version = "3.3.1";
name = "${pname}-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is done automatically and should be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah but it is used in the installPhase when linking the binary.

Is there a way to access the generated version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keeping it around is fine

jonringer
jonringer approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 102972 1

1 package built:
  • plexamp

@jonringer jonringer merged commit 52b180a into NixOS:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@jonringer jonringer jonringer approved these changes

@killercup killercup Awaiting requested review from killercup

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@afontaine @SuperSandro2000 @jonringer