Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.vim-easyclip: init at 2019-02-18 #101740

Closed
wants to merge 1 commit into from
Closed

vimPlugins.vim-easyclip: init at 2019-02-18 #101740

wants to merge 1 commit into from

Conversation

Aptrug
Copy link

@Aptrug Aptrug commented Oct 26, 2020 •
edited

Motivation for this change
Things done

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions

  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

  • Tested execution of all binary files (usually in ./result/bin/)

  • Determined the impact on package closure size (by running nix path-info -S before and after)

  • Ensured that relevant documentation is up to date

  • Fits CONTRIBUTING.md.

@Aptrug Aptrug closed this Oct 26, 2020
@SuperSandro2000
Copy link
Member

@Aptrug Do you need help with anything?

@Aptrug
Copy link
Author

Aptrug commented Oct 26, 2020 •
edited

@SuperSandro2000 It seems to me that I didn't follow this guide https://nixos.wiki/wiki/Vim#Adding_new_plugins, so I closed this PR. I'll open a new one soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Aptrug @SuperSandro2000 @Janik-Haag