-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented Preferences System #252
Merged
Merged
+1,555
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was needed as master couldn't be merged into gui-dev cleanly due to the submodule refactoring.
Migrate the gui-dev changes to a gui-dev-new branch.
@nshcat Build fails on Windows, please fix before we merge. |
I am aware that there are still are build errors on Windows, but my Windows VM is acting up - will investigate on a real Windows PC tomorrow. |
OK. I've got other work to do anyway, just let me know when it's ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the first iteration of the preferences system.
The following features are working:
Defining preferences in the schema:
The preference tree schema is defined in
PreferenceManager::InitializeDefaults()
. The current placeholder properties can be replaced in later PRs.The following features will be implemented in follow-up PRs, listed in order of implementation: