Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geany: 1.36.0 -> 1.37.0 #101674

Merged
merged 1 commit into from Oct 25, 2020
Merged

geany: 1.36.0 -> 1.37.0 #101674

merged 1 commit into from Oct 25, 2020

Conversation

frlan
Copy link
Member

@frlan frlan commented Oct 25, 2020

Motivation for this change

New upstream release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 25, 2020 •
edited

platforms = platforms.all; can be removed. That is the default.

Can you update the commit message to use a lowercase g?

Also builds fine on darwin.

@frlan
Copy link
Member Author

frlan commented Oct 25, 2020

@SuperSandro2000 Done

@r-burns
Copy link
Contributor

r-burns commented Oct 25, 2020

@SuperSandro2000 platforms.all is needed to build on hydra, #99995 (comment)

@frlan
Copy link
Member Author

frlan commented Oct 25, 2020

Re-added it. If it's a default now it will not hurt anyway.

@SuperSandro2000
Copy link
Member

Sorry about the wrong suggestion. I retraced a miss information from a while ago. r-burns is right.

@frlan
Copy link
Member Author

frlan commented Oct 25, 2020

@SuperSandro2000 It's ok with me -- nevermind ;)

@frlan frlan changed the title Geany: 1.36.0 -> 1.37.0 geany: 1.36.0 -> 1.37.0 Oct 25, 2020
r-burns
r-burns approved these changes Oct 25, 2020
View reviewed changes
Copy link
Contributor

@r-burns r-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM non-nixos linux

jtojnar
jtojnar approved these changes Oct 25, 2020
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ann: https://www.geany.org/news/geany-137-is-out/
Changes: https://www.geany.org/documentation/releasenotes/

@jtojnar jtojnar merged commit 30da0b7 into NixOS:master Oct 25, 2020
@frlan frlan deleted the Update/Geany/1.37.0 branch July 3, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@r-burns r-burns r-burns approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@frlan @SuperSandro2000 @r-burns @jtojnar