New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: fix libnvidia-container build #101665
Conversation
@GuillaumeDesforges Any idea what I should test here? |
@ofborg build libnvidia-container EDIT: wrong, it's |
@ofborg build nvidia-docker |
Seems to build fine. What did you run to test locally ? |
@GuillaumeDesforges Nothing thorough. I ran all the binaries without arguments to make sure that works. |
What derivation did you build ? |
Could you please edit the commit message from |
I ran |
Thanks :) sorry for the bother, I just wanted to ensure that we were talking about the same thing Looks good to me! Who should be reviewing/merging this ? poking several people who could be interested: @volth @alyssais @Mic92 @Philipp-M |
Would really love to see this merged. |
Actually, on second look, the current nvidia-docker derivation is really outdated. How it works has changed a bit and the currently used versions are old. I'm working on updating it. |
@theduke thanks ! An update would be awesome. I think it would be wise, still, to merge this for nvidia-docker to at least be usable, until your update is merged. |
@GuillaumeDesforges How does one get anything merged around here? |
Agreed. This PR should still be merged. |
LGTM, thank you! :) |
Motivation for this change
This change fixes the build of
libnvidia-container
.Closes #101517.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)