Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] goaccess: fix build on darwin #101731

Merged
merged 1 commit into from Oct 27, 2020
Merged

[20.09] goaccess: fix build on darwin #101731

merged 1 commit into from Oct 27, 2020

Conversation

r-burns
Copy link
Contributor

@r-burns r-burns commented Oct 26, 2020

Backport of #101709
(cherry picked from commit d8b38de)

Motivation for this change

ZHF 20.09 #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-burns
goaccess: fix build on darwin
edfbd83 
(cherry picked from commit d8b38de)
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 26, 2020
@ofborg ofborg bot requested a review from ederoyd46 October 26, 2020 04:16
@domenkozar domenkozar merged commit 1f40196 into NixOS:release-20.09 Oct 27, 2020
@r-burns r-burns deleted the backport-goaccess branch November 2, 2020 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ederoyd46 ederoyd46 Awaiting requested review from ederoyd46

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r-burns @domenkozar