New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20.09] treewide: mark broken for 20.09 #101736
Conversation
e76e4ed
to
3f8de00
Compare
3f8de00
to
8e0ccf7
Compare
cc issue #100111 |
cc @worldofpeace should this close ZHF. This seems like the "capstone" for stabilization |
@jonringer Yes. But people can still contribute fixes to unbreak things. Be sure to comment there as well. |
Of course, but it would be weird to have the ZHF item open indefinitely. I'll just change the original post to mention that the backport commit may need to remove "broken = true;" |
I was agreeing with "yes". |
Not sure why i read that as a rebuttable I guess I violently agree as well |
all that remains are the linux modules:
|
I will probably tackle the linux modules in a different PR, as we don't really have a good way (that I'm aware of) to determine the "flavor" of the kernel (e.g. libre, zen, xen, hardened, etc.) |
That's an awful lot of modules. |
I hope for people's hardware they can't rebuild switch because a module for the stable kernel doesn't build. Obviously something to handle after release. |
97685ed
to
b031bb9
Compare
|
going to "forward port" some of the python fixes in a different PR |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/upgrade-20-03-to-20-09-failes-due-to-brocken-libguestfs-1-40-2/9721/2 |
Motivation for this change
using git hub file changes to make sure the diff looks good
Fixes #100111
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)