You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a contribution to this years hacktoberfest i want to bump metasploit to the latest version.
Additionally I converted the maintainer comments for updating into a working shell script and added it via passthru.updateScript. I hope nixpkgs-update run by @r-ryantm will now pick up new versions automatically.
Things done
Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)
NixOS
macOS
other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
when starting I get
results/metasploit/bin/msfconsole
Following files may not be writable, so sudo is needed:
/nix/store/g57ln13r4y0z374im449lh56wzylzkqz-metasploit-bundler-env/lib/ruby/gems/2.6.0
/nix/store/g57ln13r4y0z374im449lh56wzylzkqz-metasploit-bundler-env/lib/ruby/gems/2.6.0/bin
/nix/store/g57ln13r4y0z374im449lh56wzylzkqz-metasploit-bundler-env/lib/ruby/gems/2.6.0/bin
/nix/store/g57ln13r4y0z374im449lh56wzylzkqz-metasploit-bundler-env/lib/ruby/gems/2.6.0/build_info
/nix/store/g57ln13r4y0z374im449lh56wzylzkqz-metasploit-bundler-env/lib/ruby/gems/2.6.0/build_info/nokogiri-1.10.10.info
/nix/store/g57ln13r4y0z374im449lh56wzylzkqz-metasploit-bundler-env/lib/ruby/gems/2.6.0/build_info/pg-1.2.3.info
/nix/store/g57ln13r4y0z374im449lh56wzylzkqz-metasploit-bundler-env/lib/ruby/gems/2.6.0/build_info/sqlite3-1.4.2.info
/nix/store/g57ln13r4y0z374im449lh56wzylzkqz-metasploit-bundler-env/lib/ruby/gems/2.6.0/bundler
/nix/store/g57ln13r4y0z374im449lh56wzylzkqz-metasploit-bundler-env/lib/ruby/gems/2.6.0/cache
/nix/store/g57ln13r4y0z374im449lh56wzylzkqz-metasploit-bundler-env/lib/ruby/gems/2.6.0/doc
/nix/store/g57ln13r4y0z374im449lh56wzylzkqz-metasploit-bundler-env/lib/ruby/gems/2.6.0/extensions
/nix/store/g57ln13r4y0z374im449lh56wzylzkqz-metasploit-bundler-env/lib/ruby/gems/2.6.0/gems
/nix/store/g57ln13r4y0z374im449lh56wzylzkqz-metasploit-bundler-env/lib/ruby/gems/2.6.0/specifications
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
As a contribution to this years hacktoberfest i want to bump metasploit to the latest version.
Additionally I converted the maintainer comments for updating into a working shell script and added it via
passthru.updateScript. I hopenixpkgs-updaterun by @r-ryantm will now pick up new versions automatically.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)/nix/store/v3fqbxmscrgr0dy456cn9adq8sf78c93-metasploit-framework-5.0.90 1028103384/nix/store/dixmayl4s2kddr0yql3zrgs1fjvl9gms-metasploit-framework-6.0.4 1012865360nix-shell maintainers/scripts/update.nix --argstr path metasploit