New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
whalebird: init at 4.3.1 #101689
whalebird: init at 4.3.1 #101689
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know anything about packaging electron
apps, but I did notice two minor things you could fixup.
Thank you! Fixed now. |
I'm not qualified to review Electron specific packages.
Result of 1 package built:
|
Updated to 4.3.0 |
}; | ||
|
||
in appimageTools.wrapType2 rec { | ||
name = pname; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name = pname; | |
name = "${pname}-${version}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except this is a bad idea, because that is the name appimageTools uses for the program binary name. I'll revert this.
Result of 1 package built:
|
15ed53a
to
82d4a8d
Compare
I marked this as stale due to inactivity. → More info |
@greydot pls update your fork to fix merge conflict. |
|
||
extraInstallCommands = '' | ||
mkdir "$out/share" | ||
ln -s "${desktopItem}/share/applications" "$out/share/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use copyDeskopItems here?
Someone else added this package. Closing. |
Motivation for this change
Introduce Whalebird.
Things done
Added whalebird derivation for Linux x64.
Note that while it is an open source app, building it from source is nigh impossible due to Electron being weird :(
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)