Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] itk: remove -march=corei7 and -mtune=native flags from cmake build files #100757

Merged
merged 1 commit into from Oct 17, 2020
Merged

[20.09] itk: remove -march=corei7 and -mtune=native flags from cmake build files #100757

merged 1 commit into from Oct 17, 2020

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Oct 16, 2020 •
edited

  • probable cause of build failure on Hydra on branch release-20.09

(cherry picked from commit 83a1ce3)

Backport of #100659 for ZHF (#97479).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bcdarwin
itk: remove -march=corei7 and -mtune=native flags from cmake build files
355a372 
- probable cause of build failure on Hydra on branch release-20.09

(cherry picked from commit 83a1ce3)
@bcdarwin bcdarwin changed the title itk: remove -march=corei7 and -mtune=native flags from cmake build files [20.09] itk: remove -march=corei7 and -mtune=native flags from cmake build files Oct 16, 2020
@ofborg ofborg bot requested a review from viric October 16, 2020 20:48
jonringer
jonringer approved these changes Oct 17, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

https://github.com/NixOS/nixpkgs/pull/100757
2 packages built:
elastix itk

@jonringer jonringer merged commit 8a10daf into NixOS:release-20.09 Oct 17, 2020
@bcdarwin bcdarwin deleted the fix-itk-flags-20.09 branch October 18, 2020 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@viric viric Awaiting requested review from viric

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bcdarwin @jonringer