Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

koreader: 2020.09 -> 2020.11 #100763

Merged
merged 2 commits into from Nov 18, 2020
Merged

koreader: 2020.09 -> 2020.11 #100763

merged 2 commits into from Nov 18, 2020

Conversation

neonfuz
Copy link
Contributor

@neonfuz neonfuz commented Oct 16, 2020

Motivation for this change

Version bump

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from contrun October 16, 2020 22:08
@contrun
Copy link
Contributor

contrun commented Oct 18, 2020

LGTM. nix-review build succeeded. Was able to run the newly built koreader

@neonfuz neonfuz changed the title koreader: 2020.09 -> 2020.10.1 koreader: 2020.09 -> 2020.11 Nov 16, 2020
@ofborg ofborg bot requested a review from contrun November 16, 2020 22:04
contrun
contrun approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@contrun contrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A working ./result/koreader/bin/koreader is buitl with nix-review pr 100763.

@contrun contrun mentioned this pull request Nov 18, 2020
Closed
@ryantm ryantm merged commit e5e08a5 into NixOS:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@contrun contrun contrun approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@neonfuz @contrun @ryantm