Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] devpi-server: fix tests #100751

Merged
merged 1 commit into from Oct 17, 2020
Merged

[20.09] devpi-server: fix tests #100751

merged 1 commit into from Oct 17, 2020

Conversation

jfroche
Copy link
Contributor

@jfroche jfroche commented Oct 16, 2020

Tests relied on a function that has no order guarantee. A fix was merged
to devpi master [1]. We point the package to this commit which should fix
the failing tests on hydra.

[1] devpi/devpi#821

(cherry picked from commit 3a57ec4)

backport of #100508

ZHF: #97479
@NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jfroche
devpi-server: fix tests
ae37b66 
Tests relied on a function that has no order guarantee. A fix was merged
to devpi master [1]. We point the package to this commit which should fix
the failing tests on hydra.

[1] devpi/devpi#821

(cherry picked from commit 3a57ec4)
@jfroche
Copy link
Contributor Author

jfroche commented Oct 16, 2020

Result of nixpkgs-review pr 100751 1

2 packages built:
  • devpi-client
  • devpi-server

@ofborg ofborg bot requested a review from makefu October 16, 2020 20:02
jonringer
jonringer approved these changes Oct 17, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 100751 1

2 packages built:
  • devpi-client
  • devpi-server

@jonringer jonringer merged commit 31db508 into NixOS:release-20.09 Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@makefu makefu Awaiting requested review from makefu

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jfroche @jonringer