Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boolector: enable darwin build #100750

Merged
merged 2 commits into from Dec 2, 2020
Merged

boolector: enable darwin build #100750

merged 2 commits into from Dec 2, 2020

Conversation

arcz
Copy link
Member

@arcz arcz commented Oct 16, 2020

Motivation for this change

The build was working only on linux. For darwin, it required some dynamic library path patching since the default build doesn't set them correctly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) labels Oct 16, 2020
@ofborg ofborg bot requested a review from thoughtpolice October 16, 2020 20:11
@arcz arcz requested a review from LnL7 November 29, 2020 21:34
@arcz
Copy link
Member Author

arcz commented Nov 29, 2020

@LnL7 I've changed this PR considerably based on your comments

@thoughtpolice thoughtpolice merged commit a3ae8a4 into NixOS:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-burns r-burns r-burns left review comments

@thoughtpolice thoughtpolice thoughtpolice approved these changes

@LnL7 LnL7 Awaiting requested review from LnL7

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arcz @thoughtpolice @LnL7 @r-burns