Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: drop darwin workarounds from rust packages #100798

Merged
merged 6 commits into from Oct 22, 2020
Merged

treewide: drop darwin workarounds from rust packages #100798

merged 6 commits into from Oct 22, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Oct 17, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @danieldk @marsam

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 17, 2020
@zowoq
Copy link
Contributor Author

zowoq commented Oct 17, 2020

Draft as llvm and rust haven't been rebuilt on hydra yet since staging-next was merged.

@zowoq zowoq marked this pull request as ready for review October 21, 2020 10:22
@zowoq zowoq merged commit c70acdf into NixOS:master Oct 22, 2020
@zowoq zowoq deleted the rust-darwin branch October 22, 2020 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant