Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

knightos platforms #100804

Merged
merged 1 commit into from Oct 17, 2020
Merged

knightos platforms #100804

merged 1 commit into from Oct 17, 2020

Conversation

siraben
Copy link
Member

@siraben siraben commented Oct 17, 2020

Motivation for this change

@danieldk's suggestion to add meta.platforms (not already enforced by ofborg?)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siraben
Copy link
Member Author

siraben commented Oct 17, 2020 •
edited

Oops, botched the branch, will rebase. Apologies for the mass ping to reviewers.

@siraben siraben changed the title Knightos platforms knightos platforms Oct 17, 2020
@zowoq zowoq removed their request for review October 17, 2020 11:53
jonringer
jonringer approved these changes Oct 17, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Automatic merge went well; stopped before committing as requested
Nothing to be built.
https://github.com/NixOS/nixpkgs/pull/100804
$ nix-shell /home/jon/.cache/nixpkgs-review/pr-100804/shell.nix

@jonringer jonringer merged commit 3ed43ea into NixOS:master Oct 17, 2020
@siraben siraben deleted the knightos-platforms branch October 17, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@FRidh FRidh Awaiting requested review from FRidh

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@siraben @jonringer