Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cppcheck false positives due to LogFatal not being parsed as noreturn #237

Closed
azonenberg opened this issue Oct 17, 2020 · 0 comments
Closed
Labels
build Build system and infrastructure

Comments

@azonenberg
Copy link
Collaborator

Lots of areas in the code (e.g. AntikernelLabsOscilloscope.cpp:49) call LogFatal() if something catastrophic happens, which prints an error to all configured log sinks then aborts.

cppcheck does not seem to recognize this as a noreturn call, which leads to false positive warnings about potential null dereferences etc.

@azonenberg azonenberg added the build Build system and infrastructure label Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build system and infrastructure
Projects
None yet
Development

No branches or pull requests

1 participant