Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode: chmod +x update-vscode.sh #100461

Merged
merged 1 commit into from Oct 14, 2020
Merged

vscode: chmod +x update-vscode.sh #100461

merged 1 commit into from Oct 14, 2020

Conversation

samuela
Copy link
Member

@samuela samuela commented Oct 14, 2020

Motivation for this change

I forgot to set pkgs/applications/editors/vscode/update-vscode.sh as executable in #97938. This PR fixes that by setting it as executable. update-vscodium.sh is already marked as executable since it was already renamed from the original script.

No effect on any packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@garbas garbas merged commit e50c9ce into NixOS:master Oct 14, 2020
@samuela samuela deleted the samuela/chmod branch October 14, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samuela @garbas