Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iortcw: init at 1.51c #100485

Merged
merged 1 commit into from Nov 1, 2020
Merged

iortcw: init at 1.51c #100485

merged 1 commit into from Nov 1, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 14, 2020 •
edited by ghost

Motivation for this change

Add engine for Return to Castle Wolfenstein game

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost marked this pull request as ready for review October 14, 2020 19:28
@ghost ghost marked this pull request as draft October 15, 2020 18:03
@ghost ghost marked this pull request as ready for review October 15, 2020 19:50
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/343

@ghost
Copy link
Author

ghost commented Oct 22, 2020

@SuperSandro2000 Thanks for review!

SuperSandro2000
SuperSandro2000 reviewed Oct 26, 2020
View reviewed changes
pkgs/games/iortcw/bare.nix Outdated Show resolved Hide resolved
pkgs/games/iortcw/bare.nix Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Oct 26, 2020

@SuperSandro2000 Thanks! 😃

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 100485 run on x86_64-linux 1

2 packages built:
  • iortcw
  • iortcwBare

@ghost ghost mentioned this pull request Nov 1, 2020
Merged
10 tasks
@FRidh
Copy link
Member

FRidh commented Nov 1, 2020

Please give the two packages a different description. What is bare?

@ghost
Copy link
Author

ghost commented Nov 1, 2020

@FRidh Let's try this way

@FRidh FRidh merged commit 61040fa into NixOS:master Nov 1, 2020
@ghost
Copy link
Author

ghost commented Nov 1, 2020

@FRidh Thank you so much! 😄

@ghost ghost deleted the iortcw branch November 1, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nixos-discourse @SuperSandro2000 @FRidh