Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: De-inline uses of lib.boolToString #100456

Merged
merged 1 commit into from Oct 24, 2020
Merged

treewide: De-inline uses of lib.boolToString #100456

merged 1 commit into from Oct 24, 2020

Conversation

maralorn
Copy link
Member

This commit should not change eval results

nixpkgs-review rev HEAD said Nothing to be built.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@maralorn
treewide: De-inline uses of lib.boolToString
cebf919 
This commit should not change eval results
@maralorn
Copy link
Member Author

Result of nixpkgs-review pr 100456 1

@andir andir merged commit 250fb46 into NixOS:master Oct 24, 2020
@maralorn maralorn deleted the boolToString branch October 24, 2020 22:45
@oyren oyren mentioned this pull request Oct 26, 2020
Closed
kini added a commit to kini/nixpkgs that referenced this pull request Oct 26, 2020
@kini
lib/types.nix: fix missing inherit
a456ccb 
I think there was a silent (i.e. semantic) merge conflict between PR NixOS#101139 and
PR NixOS#100456.  This commit should fix the error, which manifests as follows:

  error: undefined variable 'boolToString' at /home/kkini/src/nixpkgs/lib/types.nix:552:42
@kini kini mentioned this pull request Oct 26, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@infinisil infinisil Awaiting requested review from infinisil infinisil is a code owner

@kalbasit kalbasit Awaiting requested review from kalbasit

@Mic92 Mic92 Awaiting requested review from Mic92

@nbp nbp Awaiting requested review from nbp

@peti peti Awaiting requested review from peti peti is a code owner

@zowoq zowoq Awaiting requested review from zowoq

Assignees
No one assigned
Labels
6.topic: golang 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maralorn @andir