New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stale bot: TL;DR #100462
stale bot: TL;DR #100462
Conversation
This comment has been minimized.
This comment has been minimized.
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/how-many-people-are-paid-to-work-on-nix-nixpkgs/8307/85 |
I have nothing against making long text shorter where possible, or improving formatting, but this PR currently also makes some changes I consider regressions:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Renderd PRHello! Thank you in the name of the community for your contributions. Very unfortunately sometimes PRs get left behind for too long.
Rendered IssueHello! Thank you in the name of the community for opening this issue. Very unfortunately sometimes issues get left behind for too long.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Doesn't this PR make the message left on issues longer? According to the diff it replaces ~164 words by ~313. In the interest of brevity it's probably best to leave out lines like "So it is my most undesired pleasure to be explicit about it:". Or advice like "5. As in all open source projects, though, by far your best option is to submit a Pull Request that addresses this issue" which is true but not super useful, since if the submitter had the ability to fix the issue, they probably would have done so already. I'm not sure a "never-stale" label is a good idea. It just means that eventually we're going to need a bot to clean up the never-stale issues... |
This comment has been minimized.
This comment has been minimized.
Another possibility is to put that information somewhere else (e.g. in the manual) and link to it from the comment. That way we don't have to duplicate a large body of text (which could get outdated) across hundreds of issues. Regarding "never-stale": yeah, it sounds fine if only maintainers can add that label. |
This comment has been minimized.
This comment has been minimized.
I think we should move it into the manual as edolstra suggests. Then the bot message can be much more minimal. |
This comment has been minimized.
This comment has been minimized.
The only time you need to find it is when the bot mentions it, and there will be a link to it. I'd also be fine with putting it in a file like I think it is a waste to put effort into this rewording when we are so close to having a place where a longer form message is okay. |
This has become really good now. Squashed & Rebased. Merge? |
The current text is an imposition on the reader, reformulate to make it short, concise and useful.
Is something still holding this back? |
@blaggacao Please review #101320 I made the stale bot message even shorter, renamed the markdown file and edited your text. |
#101320 ❤️ |
The current text is an imposition on the reader, reformulate to make it short, concise and useful.
Motivation for this change