Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analysis fails with cppcheck 1.x on VICPSocketTransport.cpp #236

Closed
azonenberg opened this issue Oct 14, 2020 · 0 comments · Fixed by #278
Closed

Analysis fails with cppcheck 1.x on VICPSocketTransport.cpp #236

azonenberg opened this issue Oct 14, 2020 · 0 comments · Fixed by #278
Assignees
@tarunik
Labels
bug Something isn't working build Build system and infrastructure

Comments

@azonenberg
Copy link
Collaborator

Since this is fixed in newer cppcheck versions, best option is probably to just not use cppcheck 1.x for analysis.

No cppcheck = nothing to do
Cppcheck 1.x = ignore and print warning
Cppcheck 2.x = use it
@azonenberg azonenberg added bug Something isn't working build Build system and infrastructure labels Oct 14, 2020
tarunik added a commit that referenced this issue Nov 6, 2020
@tarunik
Add version check to CppCheck detection, so we can ignore obsolete 1.…
2d18450 
…x versions. This fixes #236.
@azonenberg azonenberg linked a pull request Nov 6, 2020 that will close this issue
Add version check to CppCheck detection, fixing #236 #278
Merged
azonenberg added a commit that referenced this issue Nov 6, 2020
@azonenberg
Merge pull request #278 from azonenberg/cppcheck-version
c5a46d0 
Add version check to CppCheck detection, fixing #236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tarunik tarunik

Labels
bug Something isn't working build Build system and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add version check to CppCheck detection, fixing #236 ngscopeclient/scopehal-apps
2 participants
@azonenberg @tarunik