Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIDIVisualizer: 5.1 -> 5.2 #101006

Merged
merged 1 commit into from Nov 23, 2020
Merged

MIDIVisualizer: 5.1 -> 5.2 #101006

merged 1 commit into from Nov 23, 2020

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change

Update failed in https://r.ryantm.com/log/2020-10-17.log for no apparent reason.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from ericdallo October 18, 2020 17:13
@SuperSandro2000 SuperSandro2000 merged commit a9f8357 into NixOS:master Nov 23, 2020
@SuperSandro2000 SuperSandro2000 deleted the MIDIVisualizer-5.2 branch November 23, 2020 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericdallo ericdallo ericdallo approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuperSandro2000 @ericdallo