Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible-lint: 4.2.0 -> 4.3.5 #101021

Merged
merged 2 commits into from Oct 19, 2020
Merged

ansible-lint: 4.2.0 -> 4.3.5 #101021

merged 2 commits into from Oct 19, 2020

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change

Update failed in https://r.ryantm.com/log/2020-10-17.log.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from sengaya October 18, 2020 19:15
@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 101021 1

2 package built:
  • ansible-lint (python38Packages.ansible-lint)
  • python37Packages.ansible-lint

@sengaya
Copy link
Contributor

sengaya commented Oct 19, 2020

Many thanks for the PR. Unfortunately a build on MacOS fails at the moment for me. For some reason the dependency cairo does not build. Seems unrelated to your PR though. I need to dig deeper.

For the record, this is the error:

./cairo-mutex-impl-private.h:262:3: error: "XXX: No mutex implementation found.  Cairo will not work with multiple threads.  Define CAIRO_NO_MUTEX to 1 to acknowledge and accept this limitation and compile cairo without thread-safety support."

@SuperSandro2000
Copy link
Member Author

No mutex implementation found

Maybe this helps you debugging this issue https://gitlab.freedesktop.org/cairo/cairo/-/issues/121

jonringer
jonringer approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 101021 1

2 packages built:
  • ansible-lint (python38Packages.ansible-lint)
  • python37Packages.ansible-lint

@jonringer jonringer merged commit 77d5e86 into NixOS:master Oct 19, 2020
@SuperSandro2000 SuperSandro2000 deleted the ansible-lint-4.3.5 branch October 19, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@sengaya sengaya Awaiting requested review from sengaya

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SuperSandro2000 @sengaya @jonringer