Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] python3Package.pytest-flask: remove support for python 2.7 #101036

Merged
merged 1 commit into from Oct 19, 2020
Merged

[20.09] python3Package.pytest-flask: remove support for python 2.7 #101036

merged 1 commit into from Oct 19, 2020

Conversation

jfroche
Copy link
Contributor

@jfroche jfroche commented Oct 18, 2020

As stated in its changelog [1], python 2.7 is no longer supported.

[1] https://github.com/pytest-dev/pytest-flask/blob/master/docs/changelog.rst

Backport #100525
ZHF: #97479
@NixOS/nixos-release-managers
Fixes https://hydra.nixos.org/build/127652828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jfroche
python3Package.pytest-flask: remove support for python 2.7
d63a350 
As stated in its changelog [1], python 2.7 is no longer supported.

[1] https://github.com/pytest-dev/pytest-flask/blob/master/docs/changelog.rst

(cherry picked from commit e07cf5d)
@jfroche
Copy link
Contributor Author

jfroche commented Oct 18, 2020

Result of nixpkgs-review pr 101036 1

5 packages built:
  • flexget
  • python37Packages.flask-restx
  • python37Packages.pytest-flask
  • python38Packages.flask-restx
  • python38Packages.pytest-flask

@jfroche jfroche changed the title python3Package.pytest-flask: remove support for python 2.7 [20.09] python3Package.pytest-flask: remove support for python 2.7 Oct 18, 2020
@ofborg ofborg bot requested a review from vanschelven October 18, 2020 22:20
jonringer
jonringer approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 101036 1

5 packages built:
  • flexget
  • python37Packages.flask-restx
  • python37Packages.pytest-flask
  • python38Packages.flask-restx
  • python38Packages.pytest-flask

@jonringer jonringer merged commit c8a4fd8 into NixOS:release-20.09 Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@vanschelven vanschelven Awaiting requested review from vanschelven

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jfroche @jonringer