Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] python{2,3}Packages.galario: 1.2.1 -> 1.2.2 #101035

Merged
merged 1 commit into from Oct 19, 2020
Merged

[20.09] python{2,3}Packages.galario: 1.2.1 -> 1.2.2 #101035

merged 1 commit into from Oct 19, 2020

Conversation

jfroche
Copy link
Contributor

@jfroche jfroche commented Oct 18, 2020

Upgrading fixes the tests

(cherry picked from commit cbd37d0)

Backport #100767
ZHF: #97479
cc @NixOS/nixos-release-managers
fix https://hydra.nixos.org/build/127623662

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jfroche
python{2,3}Packages.galario: 1.2.1 -> 1.2.2
5749abe 
Upgrading fixes the tests

(cherry picked from commit cbd37d0)
@jfroche
Copy link
Contributor Author

jfroche commented Oct 18, 2020

Result of nixpkgs-review pr 101035 1

4 packages built:
  • galario
  • python27Packages.galario
  • python37Packages.galario
  • python38Packages.galario

@ofborg ofborg bot requested a review from smaret October 18, 2020 22:17
@mweinelt
Copy link
Member

mweinelt commented Oct 19, 2020 •
edited

Please use git cherry-pick -x to backport commits. Applies to your other 20.09 backports as well.

@jfroche
Copy link
Contributor Author

jfroche commented Oct 19, 2020

@mweinelt Can you double check ? I already used cherry pick with -x with commit on master. Same for the other PR

@mweinelt
Copy link
Member

Oh yeah, this is odd. In some views GitHub only shows the shortened hash, while in others it shows the full one.

@mweinelt mweinelt merged commit d7f29f9 into NixOS:release-20.09 Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@smaret smaret Awaiting requested review from smaret

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jfroche @mweinelt