pine64-pinephone: Modem support improvements #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kernel shouldn't be compressed for our current usage. Otherwise we need to do more work with U-Boot.
The following from megi's have to be disabled (not set) or else the console logo will not show up at boot (pre-init). > CONFIG_FRAMEBUFFER_CONSOLE_ROTATION > CONFIG_FRAMEBUFFER_CONSOLE_DEFERRED_TAKEOVER
samueldr
commented
Oct 18, 2020
Comment on lines
+2
to
+4
| pine64-pinephone = { | ||
| qfirehose = final.callPackage ./qfirehose {}; | ||
| }; |
There was a problem hiding this comment.
I'm not sure adding a new top-level attribute for each device is the best solution here. Should it be under mobile-nixos instead?
samueldr
commented
Oct 18, 2020
| # | ||
| systemd.services = | ||
| let | ||
| dotDeviceName = "sys-devices-platform-soc-1c1b000.usb-usb3-3\\x2d1-3\\x2d1:1.4-net-wwan0.device"; |
There was a problem hiding this comment.
I'd like to have confirmation that this name is stable for the Pinephone 1.2 variants too.
|
This does bring up a small complication for users starting from e.g. the generic So they have to somehow first rebuild with the device configured. This is not something to worry about now, as this is not a regression. This is something that will have to be handled by whatever (human followed) process we create for installing Mobile NixOS. |
This has not been made "fancier" for easier use yet. It is unknown how useful updating the firmware is. Usage: ``` $ NIXPKGS_ALLOW_UNFREE=1 nix-build --argstr device pine64-pinephone -A pkgs.pine64-pinephone.qfirehose $ sudo ./result/bin/QFirehose -l ./ -f ./newfw ``` But maybe read more about whether you want to update or not beforehand? https://forum.pine64.org/showthread.php?tid=11815
samueldr
force-pushed
the
feature/pinephone/modem
branch
from
8680341
to
0827701
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the modem usable.
Update to megi's fork of mainline Linux
This is AFAICT the better option for hardware support. More details on their website.
This, in turn, gives us kernel 5.9
With this fork I was able to confirm LTE data working with Modem Manager, which already is present when Network Manager is. Though YMMV. Calls/SMS have not been tested yet considering I don't have a plan with those for the time being.
I guess SMS would work if you had software that handles them. Calls might work, but probably need some twiddling with ALSA and such to work. They'll be tested and fixed at a later time.
modem-controlserviceThis systemd service can be used to query the state of the modem (might not be 100% reliable during its boot and poweroff stages), and to control it also. Note that the service status is bound to the modem device presence, which in turn means that powering it on/off manually from the sysfs node will not confuse the service state.
If you want to disable it by default on your system you can add the following to your configuration:
Note that the modem is still turned off by default in U-Boot. This is probably not going to change. Sure, this makes the apparent boot-up of the phone part of the phone longer, but for the time being this is the way the modem is being configured by default on start. This gives better control for a user that wants their modem to be powered off by default.
When Mobile NixOS is much closer to being user-friendly we might revisit its default state during boot-up.
Modem firmware updater
Read the forum thread to know whether you want to update or not. The updater has been packaged, but not made user-friendly as currently it is... debatable... what should be happening here.
The commit introducing the change has more notes in its body detailing how to use the updater.