Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] kdeApplications.kpat: restore #100992

Merged
merged 1 commit into from Oct 19, 2020
Merged

[20.09] kdeApplications.kpat: restore #100992

merged 1 commit into from Oct 19, 2020

Conversation

KamilaBorowska
Copy link
Member

@KamilaBorowska KamilaBorowska commented Oct 18, 2020 •
edited

Motivation for this change

Restore kpat that was accidentally removed in NixOS 20.09. IMO not being able to play FreeCell on 20.09 is a huge regression (not really, albeit it's still a regression). This doesn't affect 20.03 or unstable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Also played FreeCell.

@KamilaBorowska
Copy link
Member Author

@ofborg build kdeApplications.kpat

@KamilaBorowska
Copy link
Member Author

KamilaBorowska commented Oct 18, 2020 •
edited

I guess this may be ZHF: #97479 (after all the goal of ZHF is to "have all deliverables that worked in the previous release work here also" - a missing package doesn't cause Hydra failure, but I don't think it's desirable either), so may as well ping @NixOS/nixos-release-managers.

@jonringer jonringer merged commit af136e9 into NixOS:release-20.09 Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KamilaBorowska @jonringer