Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] libreoffice-qt: fix compilation #101020

Merged
merged 1 commit into from Oct 21, 2020
Merged

[20.09] libreoffice-qt: fix compilation #101020

merged 1 commit into from Oct 21, 2020

Conversation

jmpunkt
Copy link
Contributor

@jmpunkt jmpunkt commented Oct 18, 2020 •
edited

(cherry picked from commit 6e72633)

Motivation for this change

Backport of #97640 to fix the compilation, currently fails on hydra.

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marius851000 @jmpunkt
libreoffice-qt: fix compilation
6fff872 
(cherry picked from commit 6e72633)
@AndersonTorres AndersonTorres merged commit ddf80b0 into NixOS:release-20.09 Oct 21, 2020
@jmpunkt jmpunkt deleted the libreoffice-qt-backport branch November 13, 2020 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmpunkt @AndersonTorres @marius851000