Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes: 1.19.1 -> 1.19.3 #101025

Merged
merged 1 commit into from Oct 19, 2020
Merged

kubernetes: 1.19.1 -> 1.19.3 #101025

merged 1 commit into from Oct 19, 2020

Conversation

johanot
Copy link
Contributor

@johanot johanot commented Oct 18, 2020 •
edited

Motivation for this change

Various bugfixes for kubernetes 1.19

and perhaps most importantly: fixes multiple CVE's regarding secret leaks through logs, see: https://discuss.kubernetes.io/t/security-advisory-multiple-secret-leaks-when-verbose-logging-is-enabled/13282

Kubernetes tests pass locally.

Please cherry-pick to 20.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from offlinehacker October 18, 2020 19:49
saschagrunert
saschagrunert approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Closed #98153

@srhb srhb merged commit 902e099 into NixOS:master Oct 19, 2020
@johanot johanot deleted the kubernetes-1.19.3 branch October 19, 2020 09:59
srhb pushed a commit to srhb/nixpkgs that referenced this pull request Oct 19, 2020
@srhb
kubernetes: 1.19.1 -> 1.19.3
c157bc7 
(cherry picked from commit c1fa775)
Backport of NixOS#101025
@srhb srhb mentioned this pull request Oct 19, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johanot @saschagrunert @srhb