python3Packages.google_auth: 1.20.1 -> 1.22.1 #101029

austinbutler · 2020-10-18T19:55:39Z

Motivation for this change

Upgrades google_auth, fixes many Google Cloud packages. Will backport to 20.09 for ZHF.

https://hydra.nixos.org/build/127647323

Things done

austinbutler · 2020-10-18T23:07:37Z

As I figured it might, this package requiring an updated google_auth opens a whole can of worms. That said, it's almost entirely various google-cloud Python packages so doesn't seem insurmountable. I'll see if I can tackle it, but if there's a particular way such a process needs to go please let me know.

2 packages marked as broken and skipped:
kmymoney python37Packages.rl-coach

40 packages failed to build:
dvc-with-remotes patroni python37Packages.google_cloud_automl python37Packages.google_cloud_bigquery python37Packages.google_cloud_bigtable python37Packages.google_cloud_container python37Packages.google_cloud_core python37Packages.google_cloud_datastore python37Packages.google_cloud_dns python37Packages.google_cloud_error_reporting python37Packages.google_cloud_firestore python37Packages.google_cloud_logging python37Packages.google_cloud_resource_manager python37Packages.google_cloud_runtimeconfig python37Packages.google_cloud_spanner python37Packages.google_cloud_storage python37Packages.google_cloud_texttospeech python37Packages.google_cloud_trace python37Packages.google_cloud_translate python37Packages.google_cloud_websecurityscanner python37Packages.tensorflow-bin_2 python38Packages.cirq python38Packages.google_cloud_automl python38Packages.google_cloud_bigquery python38Packages.google_cloud_bigtable python38Packages.google_cloud_container python38Packages.google_cloud_core python38Packages.google_cloud_datastore python38Packages.google_cloud_dns python38Packages.google_cloud_error_reporting python38Packages.google_cloud_firestore python38Packages.google_cloud_logging python38Packages.google_cloud_resource_manager python38Packages.google_cloud_runtimeconfig python38Packages.google_cloud_spanner python38Packages.google_cloud_storage python38Packages.google_cloud_texttospeech python38Packages.google_cloud_trace python38Packages.google_cloud_translate python38Packages.google_cloud_websecurityscanner

austinbutler · 2020-10-20T05:11:32Z

All right, worked through all the issues except a Tensorflow package that doesn't build on master anyways.

austinbutler · 2020-10-28T20:49:44Z

@jonringer @costrouc mind taking a look? Also now that 20.09 is released would I still backport this?

jonringer · 2020-10-28T20:53:30Z

@jonringer @costrouc mind taking a look? Also now that 20.09 is released would I still backport this?

you may have to remove some "broken = true;", but yea. I'm fine with backporting non-major bumps. And if it doesn't cause regressions.

jonringer · 2020-10-28T20:54:07Z

only one I'm concerned about backporting:

python3Packages.google_cloud_automl: 1.0.1 -> 2.0.0

jonringer · 2020-10-28T21:12:24Z

pkgs/development/python-modules/google_cloud_bigquery/default.nix

+    pyarrow
+  ];
+
+  # prevent google directory from shadowing google imports
  # call_api_applying_custom_retry_on_timeout requires credentials
  # test_magics requires modifying sys.path
  checkPhase = ''


maybe disable this test?

builder for '/nix/store/2nm6nj24sswksj2p5gw7myyddpbywg4l-python3.8-google-cloud-bigquery-2.1.0.drv' failed with exit code 1; last 10 log lines: E datetime.datetime(4567, 1, 1, 0, 0) E E + [datetime.datetime(4567, 1, 1, 0, 0), datetime.datetime(9999, 12, 31, 0, 0)] E - [datetime.datetime(4567, 1, 1, 0, 0, tzinfo=<UTC>), E - datetime.datetime(9999, 12, 31, 0, 0, tzinfo=<UTC>)] tests/unit/test_table.py:2294: AssertionError =========================== short test summary info ============================ FAILED tests/unit/test_table.py::TestRowIterator::test_to_dataframe_timestamp_out_of_pyarrow_bounds ========== 1 failed, 1372 passed, 54 skipped, 1 deselected in 14.60s ===========

pytestCheckHook would make this easy

Strange, all tests pass on my machine. Just checked again with nix-build -A python38Packages.google_cloud_bigquery. I can disable the test, though.

austinbutler · 2020-10-28T21:43:48Z

@jonringer @costrouc mind taking a look? Also now that 20.09 is released would I still backport this?

you may have to remove some "broken = true;", but yea. I'm fine with backporting non-major bumps. And if it doesn't cause regressions.

Not sure what you mean. I didn't explicitly add any broken = true at least. This is probably my own lack of knowledge.

only one I'm concerned about backporting:
python3Packages.google_cloud_automl: 1.0.1 -> 2.0.0

Are you still evaluating or do you want me to look into if it's possible to keep this on 1.x?

jonringer · 2020-10-29T16:05:25Z

Not sure what you mean. I didn't explicitly add any broken = true at least. This is probably my own lack of knowledge.

I did on release-20.09, as part of the release #101736

jonringer · 2020-10-29T16:26:22Z

Are you still evaluating or do you want me to look into if it's possible to keep this on 1.x?

For backporting, I would prefer not to backport this, unless it's already broken

austinbutler · 2020-10-30T21:37:28Z

Are you still evaluating or do you want me to look into if it's possible to keep this on 1.x?

For backporting, I would prefer not to backport this, unless it's already broken

Just checked and this one was not broken on 20.09. So I will keep that in mind when backporting.

austinbutler · 2020-11-03T01:20:54Z

@jonringer would you mind taking another look? I think this is good to go.

austinbutler · 2020-11-06T17:29:23Z

@jonringer pretty please? 🙇

jonringer · 2020-11-06T17:31:18Z

oh yea, sorry, last time it was just taking longer than expected to review these packages

jonringer

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/101029
2 packages marked as broken and skipped:
kmymoney python37Packages.rl-coach

1 package failed to build:
python37Packages.tensorflow-bin_2

118 packages built:
beancount deja-dup duplicity duply dvc-with-remotes fava gcalcli ledger2beancount lieer patroni python37Packages.beancount python37Packages.beancount_docverif python37Packages.cirq python37Packages.goobook python37Packages.google-auth-httplib2 python37Packages.google-auth-oauthlib python37Packages.google-cloud-access-context-manager python37Packages.google-cloud-iam python37Packages.google-cloud-org-policy python37Packages.google_api_core python37Packages.google_api_python_client python37Packages.google_auth python37Packages.google_cloud_asset python37Packages.google_cloud_automl python37Packages.google_cloud_bigquery python37Packages.google_cloud_bigquery_datatransfer python37Packages.google_cloud_bigtable python37Packages.google_cloud_container python37Packages.google_cloud_core python37Packages.google_cloud_dataproc python37Packages.google_cloud_datastore python37Packages.google_cloud_dlp python37Packages.google_cloud_dns python37Packages.google_cloud_error_reporting python37Packages.google_cloud_firestore python37Packages.google_cloud_iot python37Packages.google_cloud_kms python37Packages.google_cloud_language python37Packages.google_cloud_logging python37Packages.google_cloud_monitoring python37Packages.google_cloud_pubsub python37Packages.google_cloud_redis python37Packages.google_cloud_resource_manager python37Packages.google_cloud_runtimeconfig python37Packages.google_cloud_secret_manager python37Packages.google_cloud_securitycenter python37Packages.google_cloud_spanner python37Packages.google_cloud_speech python37Packages.google_cloud_storage python37Packages.google_cloud_tasks python37Packages.google_cloud_testutils python37Packages.google_cloud_texttospeech python37Packages.google_cloud_trace python37Packages.google_cloud_translate python37Packages.google_cloud_videointelligence python37Packages.google_cloud_vision python37Packages.google_cloud_websecurityscanner python37Packages.gspread python37Packages.kubernetes python37Packages.proto-plus python37Packages.pydrive python37Packages.tensorflow-tensorboard_2 python37Packages.weboob python38Packages.beancount_docverif python38Packages.cirq python38Packages.goobook python38Packages.google-auth-httplib2 python38Packages.google-auth-oauthlib python38Packages.google-cloud-access-context-manager python38Packages.google-cloud-iam python38Packages.google-cloud-org-policy python38Packages.google_api_core python38Packages.google_api_python_client python38Packages.google_auth python38Packages.google_cloud_asset python38Packages.google_cloud_automl python38Packages.google_cloud_bigquery python38Packages.google_cloud_bigquery_datatransfer python38Packages.google_cloud_bigtable python38Packages.google_cloud_container python38Packages.google_cloud_core python38Packages.google_cloud_dataproc python38Packages.google_cloud_datastore python38Packages.google_cloud_dlp python38Packages.google_cloud_dns python38Packages.google_cloud_error_reporting python38Packages.google_cloud_firestore python38Packages.google_cloud_iot python38Packages.google_cloud_kms python38Packages.google_cloud_language python38Packages.google_cloud_logging python38Packages.google_cloud_monitoring python38Packages.google_cloud_pubsub python38Packages.google_cloud_redis python38Packages.google_cloud_resource_manager python38Packages.google_cloud_runtimeconfig python38Packages.google_cloud_secret_manager python38Packages.google_cloud_securitycenter python38Packages.google_cloud_spanner python38Packages.google_cloud_speech python38Packages.google_cloud_storage python38Packages.google_cloud_tasks python38Packages.google_cloud_testutils python38Packages.google_cloud_texttospeech python38Packages.google_cloud_trace python38Packages.google_cloud_translate python38Packages.google_cloud_videointelligence python38Packages.google_cloud_vision python38Packages.google_cloud_websecurityscanner python38Packages.gspread python38Packages.kubernetes python38Packages.proto-plus python38Packages.pydrive python38Packages.tensorflow-tensorboard_2 python38Packages.weboob s3ql tuijam wal_e

austinbutler · 2020-11-06T17:58:18Z

oh yea, sorry, last time it was just taking longer than expected to review these packages

All good, was just making me anxious since it was a large amount of packages and already had to merge in new changes once or twice. Thank you!

austinbutler requested review from FRidh and jonringer as code owners October 18, 2020 19:55

austinbutler force-pushed the fix-google-cloud-kms branch 2 times, most recently from 13b53eb to ccc83b0 Compare October 18, 2020 20:02

ofborg bot added 6.topic: python 8.has: clean-up labels Oct 18, 2020

ofborg bot requested a review from costrouc October 18, 2020 20:33

ofborg bot added 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 labels Oct 18, 2020

austinbutler marked this pull request as draft October 19, 2020 06:48

ofborg bot requested a review from limeytexan October 19, 2020 22:15

austinbutler force-pushed the fix-google-cloud-kms branch from d24f006 to e3d40e5 Compare October 20, 2020 04:21

ofborg bot added the 8.has: package (new) label Oct 20, 2020

austinbutler changed the title ~~python3Packages.google_cloud_kms: 2.0.1 -> 2.2.0~~ python3Packages.google_auth: 1.20.1 -> 1.22.1 Oct 20, 2020

austinbutler force-pushed the fix-google-cloud-kms branch from 8bd28ed to 8098d2a Compare October 20, 2020 05:10

austinbutler marked this pull request as ready for review October 20, 2020 05:11

jonringer reviewed Oct 28, 2020

View reviewed changes

austinbutler force-pushed the fix-google-cloud-kms branch from 8098d2a to b924871 Compare October 30, 2020 21:36

austinbutler requested a review from jonringer October 30, 2020 21:37

austinbutler added 20 commits November 2, 2020 17:13

python3Packages.google-cloud-iam: init at 2.0.0

ffd9105

python3Packages.google_api_core: 1.22.1 -> 1.22.4

3b71309

python3Packages.google_auth: 1.20.1 -> 1.22.1

06f5755

python3Packages.google_cloud_automl: 1.0.1 -> 2.0.0

2a963ed

python3Packages.google_cloud_bigquery: 1.26.1 -> 2.1.0

7c36b54

python3Packages.google_cloud_container: 2.0.1 -> 2.1.0

a893f59

python3Packages.google_cloud_core: 1.4.1 -> 1.4.3

3fdb53a

python3Packages.google_cloud_error_reporting: 0.34.0 -> 1.0.0

900b689

python3Packages.google_cloud_kms: 2.0.1 -> 2.2.0

5547f7d

python3Packages.google_cloud_logging: fix tests

2a97c06

python3Packages.google_cloud_pubsub: 1.7.0 -> 2.1.0

af4347a

python3Packages.google_cloud_resource_manager: fix tests

afaa06f

python3Packages.google_cloud_runtimeconfig: fix tests

36473e0

python3Packages.google_cloud_spanner: 1.17.1 -> 1.19.1

f2ea990

python3Packages.google_cloud_storage: fix tests

ff9503e

pythonPackages.google_cloud_testutils: unstable -> 0.1.0

2048df7

python3Packages.google_cloud_texttospeech: fix build

cfdd950

python3Packages.google_cloud_translate: fix tests

d2813d6

python3Packages.google_cloud_websecurityscanner: fix build

262188f

patroni: fix tests

1706241

austinbutler force-pushed the fix-google-cloud-kms branch from 87dce67 to 1706241 Compare November 3, 2020 01:20

jonringer approved these changes Nov 6, 2020

View reviewed changes

jonringer merged commit a361626 into NixOS:master Nov 6, 2020

austinbutler deleted the fix-google-cloud-kms branch November 6, 2020 17:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

python3Packages.google_auth: 1.20.1 -> 1.22.1 #101029

python3Packages.google_auth: 1.20.1 -> 1.22.1 #101029

austinbutler commented Oct 18, 2020 •

edited

austinbutler commented Oct 18, 2020 •

edited

austinbutler commented Oct 20, 2020

austinbutler commented Oct 28, 2020 •

edited

jonringer commented Oct 28, 2020

jonringer commented Oct 28, 2020 •

edited

jonringer Oct 28, 2020

jonringer Oct 28, 2020

austinbutler Oct 28, 2020

austinbutler Oct 30, 2020

austinbutler commented Oct 28, 2020

jonringer commented Oct 29, 2020

jonringer commented Oct 29, 2020

austinbutler commented Oct 30, 2020

austinbutler commented Nov 3, 2020

austinbutler commented Nov 6, 2020

jonringer commented Nov 6, 2020

jonringer left a comment

austinbutler commented Nov 6, 2020

python3Packages.google_auth: 1.20.1 -> 1.22.1 #101029

python3Packages.google_auth: 1.20.1 -> 1.22.1 #101029

Conversation

austinbutler commented Oct 18, 2020 • edited

Motivation for this change

Things done

austinbutler commented Oct 18, 2020 • edited

austinbutler commented Oct 20, 2020

austinbutler commented Oct 28, 2020 • edited

jonringer commented Oct 28, 2020

jonringer commented Oct 28, 2020 • edited

jonringer Oct 28, 2020

Choose a reason for hiding this comment

jonringer Oct 28, 2020

Choose a reason for hiding this comment

austinbutler Oct 28, 2020

Choose a reason for hiding this comment

austinbutler Oct 30, 2020

Choose a reason for hiding this comment

austinbutler commented Oct 28, 2020

jonringer commented Oct 29, 2020

jonringer commented Oct 29, 2020

austinbutler commented Oct 30, 2020

austinbutler commented Nov 3, 2020

austinbutler commented Nov 6, 2020

jonringer commented Nov 6, 2020

jonringer left a comment

Choose a reason for hiding this comment

austinbutler commented Nov 6, 2020

austinbutler commented Oct 18, 2020 •

edited

austinbutler commented Oct 18, 2020 •

edited

austinbutler commented Oct 28, 2020 •

edited

jonringer commented Oct 28, 2020 •

edited