Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iSCSI: add various modules and a test #101015

Closed
wants to merge 5 commits into from
Closed

iSCSI: add various modules and a test #101015

wants to merge 5 commits into from

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Oct 18, 2020

Motivation for this change

This builds on top of #97793, to provide some iSCSI stuff.

Not sure if and how useful this would be to anyone, tbh.

cc @zaninime

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from cleverca22 and zaninime October 18, 2020 18:28
@ajs124
Copy link
Member Author

ajs124 commented Oct 18, 2020

The test seems to fail currently, which is weird, because it succeeded in my tree. We're still on 20.03, though.

@ajs124
Copy link
Member Author

ajs124 commented Oct 28, 2020

In any case, I'm going to close this, for now. The code is here, if you want it, and I have worked a bit on it since and might continue to work it, but I kind of doubt anyone will be interested in this. If you are, for some reason, just comment below.

@ajs124 ajs124 closed this Oct 28, 2020
@ajs124 ajs124 deleted the init/mod/openiscsi branch February 25, 2021 22:02
@grahamc grahamc mentioned this pull request Mar 9, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleverca22 cleverca22 Awaiting requested review from cleverca22

@zaninime zaninime Awaiting requested review from zaninime

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ajs124