microaeson: Unbreak via jailbreak #101008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markus1189
force-pushed
the
haskell-unbreak-microaeson
branch
from
a9320e6
to
9fca187
Compare
cdepillabout
approved these changes
Oct 19, 2020
There was a problem hiding this comment.
Looks like it builds fine, thanks for fixing this up and leaving a PR link in the comments.
This isn't too important, but in the future, the commit message should be something like haskellPackages.microaeson: Unbreak via jailbreak so that things like @GrahamcOfBorg know that microaeson can be found in haskellPackages, instead of on the top-level.
markus1189
added a commit
to markus1189/nixpkgs
that referenced
this pull request
Oct 19, 2020
With NixOS#101008, this package builds successfully and passes all tests as well.
10 tasks
peti
pushed a commit
that referenced
this pull request
Oct 23, 2020
With #101008, this package builds successfully and passes all tests as well.
marcus7070
pushed a commit
to marcus7070/nixpkgs
that referenced
this pull request
Nov 22, 2020
With NixOS#101008, this package builds successfully and passes all tests as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Unbreak the
microaesonpackage by relaxing the pretty tight version bounds usingdoJailbreakCan hopefully be removed with haskell-hvr/microaeson#4
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)