Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/borgbackup: add backup job runtimeLimit option #100286

Closed
wants to merge 1 commit into from
Closed

nixos/borgbackup: add backup job runtimeLimit option #100286

wants to merge 1 commit into from

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Oct 12, 2020

Motivation for this change

This adds an option controlling the maximum runtime duration of backup
jobs in order to prevent silent failures through indefinite hanging.
The service is now put into an explicit failed state if this limit is
exceeded.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pacien
nixos/borgbackup: add backup job runtimeLimit option
3c3dd1a 
This adds an option controlling the maximum runtime duration of backup
jobs in order to prevent silent failures through indefinite hanging.
The service is now put into an explicit failed state if this limit is
exceeded.
@pacien pacien requested review from dotlambda and Ma27 January 11, 2021 15:56
@dotlambda
Copy link
Member

I would rather just add add a serviceConfig option that will be merged into the existing serviceConfig. But you can just use systemd.services.borgbackup-job-xyz.serviceConfig.MaxRuntimeSec.

@stale
Copy link

stale bot commented Jul 11, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 11, 2021
@pacien pacien closed this Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda Awaiting requested review from dotlambda

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: changelog 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pacien @dotlambda