Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode-extensions: some tweaks to comments #100282

Merged
merged 2 commits into from Jan 18, 2021
Merged

vscode-extensions: some tweaks to comments #100282

merged 2 commits into from Jan 18, 2021

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented Oct 11, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ggreif ggreif marked this pull request as ready for review October 14, 2020 18:44
samuela
samuela approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@samuela samuela left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but could you change the PR title to something more descriptive? The convention is generally vscode-extensions: <what you did>. You can check the contributing guide for more info!

Only minor changes to code comments. Should be easy to merge.

@ggreif ggreif changed the title Some tweaks vscode-extensions: some tweaks to comments Oct 16, 2020
rnhmjoj
rnhmjoj requested changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use the same convention for the commit messages?

@SuperSandro2000 SuperSandro2000 merged commit 32cf0e3 into NixOS:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj requested changes

@samuela samuela samuela approved these changes

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ggreif @samuela @rnhmjoj @SuperSandro2000