Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

textadept: 10.2 -> 10.8 #100266

Merged
merged 1 commit into from Oct 30, 2020
Merged

textadept: 10.2 -> 10.8 #100266

merged 1 commit into from Oct 30, 2020

Conversation

jnetod
Copy link
Contributor

@jnetod jnetod commented Oct 11, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from 7c6f434c and mirrexagon October 11, 2020 18:55
7c6f434c
7c6f434c approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@7c6f434c 7c6f434c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@bhipple
Copy link
Contributor

bhipple commented Oct 30, 2020

Result of nixpkgs-review pr 100266 1

1 package built:
- textadept

@bhipple bhipple merged commit a2aa0cb into NixOS:master Oct 30, 2020
@jnetod jnetod deleted the textadept-update branch October 30, 2020 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

@bhipple bhipple bhipple approved these changes

@mirrexagon mirrexagon Awaiting requested review from mirrexagon

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jnetod @bhipple @7c6f434c